Viktor Miller
0327d82ccf
Quick task completed fixing 4 UX/notification issues from Phase 7 testing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9.9 KiB
9.9 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | must_haves | |||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| quick-001 | 01 | execute | 1 |
|
true |
|
Purpose: Polish UX and notification quality before production deployment. Output: Updated class-notifications.php and class-pages.php with all 4 fixes.
<execution_context>
@/.claude/get-shit-done/workflows/execute-plan.md
@/.claude/get-shit-done/templates/summary.md
</execution_context>
Add a new method and hook to `DDHH_JM_Pages`:
1. Add a `setup_hooks()` static method that registers a `template_redirect` hook for the login page.
2. In the `template_redirect` callback (`maybe_redirect_logged_in_from_login`):
- Check if current page is the login page (`get_option('ddhh_jm_login_page_id')`)
- If user is logged in AND has `ddhh_provider` role: redirect to dashboard page (`get_option('ddhh_jm_dashboard_page_id')`)
- If user is logged in but NOT a provider: do nothing (let them see the page as-is)
- If user is not logged in: do nothing (show login/registration forms)
3. Register `setup_hooks()` call in the class. The main plugin orchestrator (`class-ddhh-job-manager.php`) calls static setup methods, so add `DDHH_JM_Pages::setup_hooks()` there if not already called, OR make `setup_hooks()` callable from the existing init pattern.
NOTE: Check `class-ddhh-job-manager.php` for how Pages is initialized. If Pages has no `setup_hooks()` yet, add one and register it in the main plugin class `init_hooks()` method.
This approach is simpler than modifying static page content - logged-in providers simply get redirected to their dashboard (where they already have a logout link).
**Fix A: Add job description to admin submission email (`send_admin_new_job_notification_after_submit`)**
After line 67 (where job_contact_email is fetched), add:
```php
$job_description = $post->post_content;
```
In the email body sprintf, add a "Beschreibung:" section after the contact email line and before the submission date. Truncate to 500 characters with "..." suffix if longer, to keep emails readable:
```php
$description_text = wp_strip_all_tags( $job_description );
if ( strlen( $description_text ) > 500 ) {
$description_text = substr( $description_text, 0, 500 ) . '...';
}
```
Add `"Beschreibung:\n%s\n\n"` to the format string and `$description_text` as parameter.
Also add job description to the EDIT notification (`send_admin_job_edit_notification_after_submit`) using the same pattern.
**Fix B: Fix deactivation reason timing bug (`send_admin_job_deactivation_notification`)**
ROOT CAUSE: The `transition_post_status` hook fires when `wp_update_post()` changes status to draft (class-formidable.php line 742). But the deactivation reason meta is saved AFTER that (line 756-758). So `get_post_meta($post->ID, 'job_deactivation_reason', true)` returns empty at notification time.
SOLUTION: Change the deactivation notification to hook into `ddhh_job_deactivated` action instead of `transition_post_status`. The `ddhh_job_deactivated` action fires AFTER meta is saved (class-formidable.php line 764).
In `setup_hooks()`:
- REMOVE: `add_action( 'transition_post_status', array( __CLASS__, 'send_admin_job_deactivation_notification' ), 10, 3 );`
- ADD: `add_action( 'ddhh_job_deactivated', array( __CLASS__, 'send_admin_job_deactivation_notification' ), 10, 2 );`
Update `send_admin_job_deactivation_notification` method signature:
- OLD: `( $new_status, $old_status, $post )`
- NEW: `( $post_id, $entry_id )`
Update method body:
- Get post via `get_post( $post_id )` at the top
- Remove the status transition checks (lines 233-240) since the action only fires on deactivation
- Keep all the rest (meta retrieval, email building, sending)
- The `get_post_meta( $post->ID, 'job_deactivation_reason', true )` will now work because meta is already saved
**Fix C: Make admin email links clickable HTML hyperlinks**
All three admin email methods use this pattern:
```php
$headers = array( 'Content-Type: text/html; charset=UTF-8' );
$html_body = nl2br( esc_html( $body ) );
```
The problem: `esc_html()` escapes the URL but does NOT wrap it in `<a>` tags. The Content-Type says HTML but the links are plain text.
For each of the three admin notification methods (`send_admin_new_job_notification_after_submit`, `send_admin_job_edit_notification_after_submit`, `send_admin_job_deactivation_notification`):
Replace the plain text link pattern with proper HTML. Instead of building plain text and converting with nl2br(esc_html()), build the email body as proper HTML from the start:
Change the email body construction to use HTML directly. Replace the plain text sprintf approach with an HTML template approach:
- Use `<br>` instead of `\n`
- Wrap the edit link in `<a href="...">` tag: `<a href="' . esc_url( $edit_link ) . '">Stellenangebot pruefen</a>`
- Remove the `nl2br( esc_html( $body ) )` conversion -- assign the HTML body directly
- Use `esc_html()` on individual data values (job title, author name, etc.) but NOT on the entire body
- Keep the `Content-Type: text/html; charset=UTF-8` header
Example pattern for the link section:
```php
'<br><br><a href="' . esc_url( $edit_link ) . '">Stellenangebot in WordPress bearbeiten</a>'
```
<success_criteria>
- Logged-in providers are redirected away from /anbieter-login/ to dashboard
- Admin submission emails contain the job description text
- Admin deactivation emails display the actual deactivation reason (not "Kein Grund angegeben")
- All admin email links are clickable HTML hyperlinks
- No PHP syntax errors in modified files </success_criteria>